feat: dtoss 3660 nhs id in participant man demograp#826
Conversation
…id-in-participant--man-demograp
…id-in-participant--man-demograp
|
You are only using NHS numbers to verify that the record in the database is correct, is there a plan to check the other fields as well? |
We are also verify record type where necessary and rule_ID and Rule_description . where extra columns check are needed we are verifying them for ex Amended records we are verifying givenname with a value we set as Amendedgivenname. |
MWClayson-NHS
left a comment
MWClayson-NHS
left a comment
There was a problem hiding this comment.
I'm not happy for this to be merged in it's current state.
We need to adhere to the programming guidelines in https://nhsd-confluence.digital.nhs.uk/display/DTS/Code+Reviews
Please can you sort the name spaces to adhere to the convention.
I thought you were going to use a shared class library for the code shared across the E2E tests and the smoke tests? If you need help setting that up just give me a shout.
I cannot use file_scoped_namespace_declaration in tests as i am not using one function in particular and not going to use shared libraries would like to keep them as separate entities |
…https://github.com/NHSDigital/dtos-cohort-manager into feat/DTOSS-3660-NHS--id-in-participant--man-demograp
…https://github.com/NHSDigital/dtos-cohort-manager into feat/DTOSS-3660-NHS--id-in-participant--man-demograp
charanNHS
deleted the
feat/DTOSS-3660-NHS--id-in-participant--man-demograp
branch
4 participants
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.